Skip to content

add infra_mode tag to vsphere metric #21730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

add infra_mode tag to vsphere metric #21730

wants to merge 13 commits into from

Conversation

@arbll
Copy link
Member

@arbll arbll commented Oct 23, 2025

This PR is the equivalent of DataDog/datadog-agent#42081 for vsphere metrics.

@arbll
add infra_mode tag to vsphere metric
96a6ea9 
This PR is the equivalent of DataDog/datadog-agent#42081 for vsphere metrics.
@arbll arbll requested a review from a team as a code owner October 23, 2025 08:13
@AAraKKe AAraKKe self-assigned this Oct 23, 2025
AAraKKe
AAraKKe requested changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@AAraKKe AAraKKe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arbll I left a couple of questions. Just make sure to update the tests to ensure they are testing the current behavior.

I removed the no-changelog tag as this would not qualify for that use case. Any change that is going to be included in a future release of the agent needs to include a changelog that adds visibility to what has been modified both for us and for our customers.

Thanks!

My Feedback Legend

Here's a quick guide to the prefixes I use in my comments:

praise: no action needed, just celebrate!
note: just a comment/information, no need to take any action.
question: I need clarification or I'm seeking to understand your approach.
nit: A minor, non-blocking issue (e.g., style, typo). Feel free to ignore.
suggestion: I'm proposing an improvement. This is optional but recommended.
request: A change I believe is necessary before this can be merged.

The only blocking comments are request, any other type of comment can be applied at discretion of the developer.

olivielpeau
olivielpeau reviewed Oct 23, 2025
View reviewed changes
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment about something I'm not sure about.

Also, curious if we could add a test for this

@codecov
Copy link

codecov bot commented Oct 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.00%. Comparing base (3bdbe96) to head (81db47d).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arbll arbll requested a review from a team as a code owner October 31, 2025 09:45
@datadog-official
Copy link
Contributor

datadog-official bot commented Oct 31, 2025 •
edited
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 81db47d | Docs | Datadog PR Page | Was this helpful? Give us feedback!

olivielpeau
olivielpeau approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olivielpeau olivielpeau olivielpeau approved these changes

@joepeeples joepeeples joepeeples approved these changes

@AAraKKe AAraKKe Awaiting requested review from AAraKKe

@NouemanKHAL NouemanKHAL Awaiting requested review from NouemanKHAL

Requested changes must be addressed to merge this pull request.

Assignees

@AAraKKe AAraKKe

Labels

agent/requested-changes changelog/no-changelog docs/approved documentation ecosystems/review-requested integration/vsphere product/review-requested team/agent-integrations team/documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arbll @AAraKKe @olivielpeau @NouemanKHAL @joepeeples